fix(h5p-server): package validator accepts dots in library file paths (…

…#1341)

Fixes #1339

.eslintrc.js

@@ -75,6 +75,7 @@ module.exports = {
                     'private-instance-method'
                 ]
             }
-        ]
+        ],
+        'class-methods-use-this': 0
     }
 };

packages/h5p-server/src/PackageValidator.ts

@@ -5,6 +5,7 @@ import promisepipe from 'promisepipe';
 import { WritableStreamBuffer } from 'stream-buffers';
 import * as yauzlPromise from 'yauzl-promise';
 import fsExtra from 'fs-extra';
+import upath from 'upath';
 
 import AggregateH5pError from './helpers/AggregateH5pError';
 import H5pError from './helpers/H5pError';
@@ -129,19 +130,6 @@ export default class PackageValidator {
         }
     }
 
-    /**
-     * Similar to path.join(...) but uses slashes (/) as separators regardless of OS.
-     * We have to use slashes when dealing with zip files as the specification for zips require them. If the program
-     * runs on Windows path.join(...) uses backslashes \ which don't work for zip files.
-     * @param parts The parts of the path to join
-     * @returns the full path
-     */
-    private static pathJoin(...parts: string[]): string {
-        const separator = '/';
-        const replace = new RegExp(`${separator}{1,}`, 'g');
-        return parts.join(separator).replace(replace, separator);
-    }
-
     /**
      * Validates the H5P package located at the path passed to the method.
      * @param h5pFile Path to H5P file to validate
@@ -706,7 +694,7 @@ export default class PackageValidator {
             `checking if language files in library ${jsonData.machineName}-${jsonData.majorVersion}.${jsonData.minorVersion} have the correct naming schema and are valid JSON`
         );
         const uberName = `${jsonData.machineName}-${jsonData.majorVersion}.${jsonData.minorVersion}`;
-        const languagePath = PackageValidator.pathJoin(uberName, 'language/');
+        const languagePath = upath.join(uberName, 'language/');
         const languageFileRegex = /^(-?[a-z]+){1,7}\.json$/i;
         for (const languageFileEntry of zipEntries.filter(
             (e) =>
@@ -823,7 +811,7 @@ export default class PackageValidator {
             await Promise.all(
                 jsonData.preloadedJs.map((file) =>
                     this.fileMustExist(
-                        PackageValidator.pathJoin(uberName, file.path),
+                        upath.join(uberName, file.path),
                         'library-file-missing',
                         false,
                         { filename: file.path, library: uberName }
@@ -837,7 +825,7 @@ export default class PackageValidator {
             await Promise.all(
                 jsonData.preloadedCss.map((file) =>
                     this.fileMustExist(
-                        PackageValidator.pathJoin(uberName, file.path),
+                        upath.join(uberName, file.path),
                         'library-file-missing',
                         false,
                         { filename: file.path, library: uberName }