Try to avoid 'Unable to add newly converted phar... to the list of ph… #619
Conversation
…ars, a phar with that name already exists' due to https://bugs.php.net/bug.php\?id\=75101 [skip ci]
|
@beto-aveiga would this be related to any of these issues, just so we associate this with an issue that we're tracking. |
| @@ -206,7 +206,7 @@ protected function installBinary($binary, $version, $url, $sha, $hashalgo = 'sha | |||
| else { | |||
| $cacheFolder = sys_get_temp_dir() . \DIRECTORY_SEPARATOR . $binary . \DIRECTORY_SEPARATOR . $version; | |||
| } | |||
| $cacheDestination = $cacheFolder . \DIRECTORY_SEPARATOR . $fileName; | |||
| $cacheDestination = $cacheFolder. \DIRECTORY_SEPARATOR . bin2hex(random_bytes(5)) . $fileName; | |||
There was a problem hiding this comment.
Won't this mean we effectively invalidate the cache every time, and never use it?
There was a problem hiding this comment.
Yes. I had to do this because there was an error building Tugboat.
This error happened while running the composer install.
I couldn't find any other way.
There was a problem hiding this comment.
Would it make sense to only do the random string cache file after we recognize the error that is causing us to do this. This way we still get the benefits of cache for instances where everything is working fine?
|
I think this is fixed now, and we know that this PR doesn't work as is because it just breaks the cache on every execution. Closing! |
…ars, a phar with that name already exists' due to https://bugs.php.net/bug.php\?id\=75101 [skip ci]