Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract a needs download method in the binary installer #534

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Extract a needs download method in the binary installer #534

merged 2 commits into from
Apr 17, 2024

Conversation

deviantintegral
Copy link
Member

This PR is from #114 and:

  1. Pulls out a method to document our if logic.
  2. We don't need the second file_exists() call. The first one will return if it does not exist, which means to get to the last || statement the file must exist.

@github-actions github-actions bot temporarily deployed to pantheon-pr-534 April 16, 2024 19:57 Destroyed
@justafish justafish merged commit c14854e into main Apr 17, 2024
36 checks passed
@justafish justafish deleted the needs-download-method branch April 17, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davereid davereid Awaiting requested review from davereid

@justafish justafish Awaiting requested review from justafish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deviantintegral @justafish