Use a custom build of ddev to debug yaml corruption errors #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deviantintegral
commented
Feb 23, 2024
Comment on lines
+65
to
+72
| if [ "${{ inputs.replace-ddev-binary-url }}" != "" ]; then | ||
| echo "Replacing ddev binary from ${{ inputs.replace-ddev-binary-url }}" | ||
| curl --silent --location --output /tmp/ddev.zip "${{ inputs.replace-ddev-binary-url }}" | ||
| sudo unzip -o -d /usr/bin /tmp/ddev.zip | ||
| sudo chmod +x /usr/bin/ddev | ||
| ddev --version | ||
| fi | ||
|
|
There was a problem hiding this comment.
Since I was able to reproduce this so easily in this PR, we won't want to merge this whole PR. @justafish what do you think about adding support for overriding ddev like this as a feature?
Also Randy says:
Note that you're using an obsolete technique for key install, Run curl https://apt.fury.io/drud/gpg.key | sudo apt-key add -
Also, you're using the old drud location, https://apt.fury.io/drud
There was a problem hiding this comment.
@deviantintegral sounds good! 👍
#528
deviantintegral
commented
Feb 23, 2024
| - name: Install DDEV | ||
| uses: ./drainpipe/scaffold/github/actions/common/ddev | ||
| with: | ||
| git-name: Drainpipe Bot | ||
| git-email: [email protected]# |
There was a problem hiding this comment.
@justafish is this a typo we should fix?
|
Closing as this was fixed in ddev/ddev#5893 |
|
@justafish what did you think of my two notes above, on the email address and updating the ddev install steps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/ddev/discussions/5470