Convert variables to support defaults with override #267 #268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deviantintegral
changed the title
|
@justafish this is ready for review - tests passing except whatever is going on with nightwatch. |
|
Thanks! 👍 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets callers override test directories, as asked for in #267.
Since this is really task functionality, I only added a test for the YAML directories since that seemed to be the simplest to test.
In doing that I discovered something surprising. The symfony yaml library now also ships a
yaml-lintcommand, which takes precedence over the one we were using. Sincej13k/yaml-lintused symfony under the hood, I just removed the dependency.