Remove includeFunctionRule which breaks TwigJS #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please submit your pull request against the upstream Drainpipe repository at https://github.com/Lullabot/drainpipe/pulls. Note that the drainpipe-dev code is contained inside the root |
|
@mark-casias while we wait for drainpipe to review and merge your change, let's create an add a patch to this repository. |
|
Please submit your pull request against the upstream Drainpipe repository at https://github.com/Lullabot/drainpipe/pulls. Note that the drainpipe-dev code is contained inside the root |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TwigCSFixer adds a fix which changes include tags to include functions. This works great in PHP but breaks TwigJS and subsequently, Storybook.
This PR excludes this rule per https://github.com/VincentLanglet/Twig-CS-Fixer/blob/main/docs/configuration.md
See https://github.com/Lullabot/lullabot.com-d8/issues/3957