Avoid clicking. #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An instantaneous volume change can result in a click. A linear ramp avoids this and is prevents speaker damage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An instantaneous volume change can result in a click. A linear ramp avoids this
and may prevent speaker damage.
The original experiment probably used a linear or raised-cosine ramp at the start and end of each individual tone (the paper isn't very clear, but raised cosine is pretty standard for hearing experiments). This change doesn't go that far, but it uses a linear ramp any time the gain changes. I find the difference particularly noticeable at the end of each treatment cycle.