Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix args passing & Add dom arguments support #7

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aslafy-z
Copy link

@aslafy-z aslafy-z commented Oct 9, 2018

I originally did separate commits but I fckd up and I can't open two PRs anymore. sorry for this.

This fixes #5

BREAKING CHANGE: Force the use of an array instead of infinite arguments
eg:

 LukesLazyLoader.load(['file1', 'file2'])

instead of

 LukesLazyLoader.load('file1', 'file2')

It also bring support for advanced source input, it can now be:

  • a string
  • an object
     {
         args: object[string, string] // args to pass to dom
         url: string // url to use
     	 type: string // 'css' or 'js', replace auto detection 
     }
    

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LukesLazyLoader.load broken
2 participants