Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ClassLoader.py #213

Merged
merged 1 commit into from
Oct 16, 2024

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Oct 16, 2024

Removed

  • Remove ClassLoader.py.

    importlib, in the Python standard library, is sufficient. This also reduces the number of licenses in use in the repo.

  • Remove a reference to ClassLoader.py in the pre-commit config.

@coveralls
Copy link

coveralls commented Oct 16, 2024

Coverage Status

coverage: 65.481% (+0.007%) from 65.474%
when pulling 4210e31 on kurtmckee:rm-class-loader
into 042ab5f on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

Please do not modify the file .pre-commit-config.yaml in the same commit.

In fact I would like to keep the comments in .pre-commit-config.yaml as I will use them for other Python projects.

@kurtmckee
Copy link
Contributor Author

Is it acceptable to remove the reference to ClassLoader.py in the pre-commit config? Perhaps something like:

"You may need to run pre-commit run -a multiple times to ensure pyupgrade has applied all intermediary syntax updates."

Removed
-------

* Remove `ClassLoader.py`.

  `importlib`, in the Python standard library, is sufficient.
  This also reduces the number of licenses in use in the repo.

* Remove a reference to `ClassLoader.py` in the pre-commit config.
@kurtmckee
Copy link
Contributor Author

I've un-done the removal of the comments in the pre-commit config, though I did remove the reference to ClassLoader.py and tried to make the comments more generic so they would apply to any repository, not just this one.

@LudovicRousseau LudovicRousseau merged commit 01e9a7c into LudovicRousseau:master Oct 16, 2024
26 checks passed
@kurtmckee kurtmckee deleted the rm-class-loader branch October 16, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants