Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Python 3.13 #206

Merged

Conversation

kurtmckee
Copy link
Contributor

Python 3.13 will be released in a few days (its third and final release candidate was published a few days ago).

This PR adds Python 3.13 to the tox test suite and to CI.

@coveralls
Copy link

coveralls commented Oct 4, 2024

Coverage Status

coverage: 64.913% (+3.1%) from 61.833%
when pulling 878c408 on kurtmckee:support-python-3.13
into 0f335b3 on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

Please, copy the PR description in the commit message.

@kurtmckee kurtmckee force-pushed the support-python-3.13 branch from 551dc29 to 188a17f Compare October 4, 2024 14:26
@kurtmckee
Copy link
Contributor Author

I added the text "This PR adds Python 3.13 to the tox test suite and to CI."; if you want the temporal information about the Python 3.13rc3 release a few days ago and the final 3.13.0 release coming in a few days, I can add that.

If you choose to merge the commits using the GitHub interface here, by default the merge commit will include the PR number, which helps create traceability.

@LudovicRousseau
Copy link
Owner

Yes, using the github merge feature is nice.
I would like to have a really documented commit. In 10 years when github.com will be down I want to be able to know WHY I merged the patch. So I need to have the documentation in the commit message, not just in the PR description.

10 years ago I often used to add links to mailing list archives in my patch messages. But now that the mailing list archives server is down or has moved to a new domain name the links are dead :-(.
A link to a github PR is not a valid long term solution. The description of the WHY has to be in the commit message.

So, yes, you can add more temporal information about the release of Python 3.13. That would explain why you added allow-prereleases: true in the commit.

@kurtmckee
Copy link
Contributor Author

Makes sense. I'll get this updated.

Python 3.13 will be released in a few days
(its third and final release candidate was published a few days ago).

This PR adds Python 3.13 to the tox test suite and to CI.
@kurtmckee kurtmckee force-pushed the support-python-3.13 branch from 188a17f to 878c408 Compare October 4, 2024 21:43
@LudovicRousseau LudovicRousseau merged commit b45f76f into LudovicRousseau:master Oct 6, 2024
25 checks passed
@LudovicRousseau
Copy link
Owner

Thanks

@LudovicRousseau
Copy link
Owner

I used github "rebase and merge" and the PR reference is NOT included.
So it is very important to have all the details in the commit message itself.

I do not like "Create a merge commit" as it make the git log history less linear.

@kurtmckee kurtmckee deleted the support-python-3.13 branch October 13, 2024 04:17
@kurtmckee
Copy link
Contributor Author

I do not like "Create a merge commit" as it make the git log history less linear.

There are technical disadvantages to linear commit histories. For example, GPG signatures attached to commits are discarded:

Original commit

image

Transformed commit

image

As I said before, I'll submit commits with all relevant text in the commit message, but I wanted to bring this technical disadvantage to your attention in case you weren't already aware of it.

@LudovicRousseau
Copy link
Owner

Very good point.
I had not noticed your commits where GPG signed.
I will create merge commits now.

@kurtmckee
Copy link
Contributor Author

Thank you for your consideration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants