Escalate test suite warnings to errors #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please, copy the PR description in the commit message. |
kurtmckee
force-pushed
the
escalate-test-suite-warnings
branch
from
14aaa63 to
4ffbccc
Compare
|
I've copied in the descriptive text, but not the temporal "there are currently no warnings" text. If that's still desired, I can include it. |
|
If you think it is important to be present in the PR discussion then it should also be in the commit message. You should write nice commit messages. And github will reuse them for the PR description. |
This helps ensure that warnings that CPython ignores by default -- ResourceWarning -- or that warn of pending changes -- DeprecationWarning -- cause test suite failures in CI and can be addressed. There are currently no warnings to address.
kurtmckee
force-pushed
the
escalate-test-suite-warnings
branch
from
4ffbccc to
5714c46
Compare
|
Thanks for the clear explanation! I'll work to follow that. I've updated the commit message. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps ensure that warnings that CPython ignores by default --
ResourceWarning-- or that warn of pending changes --DeprecationWarning-- cause test suite failures in CI and can be addressed.There are currently no warnings to address.