Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up coverage reporting by skipping package installation #200

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Oct 2, 2024

Also, modify the Makefile to use tox for coverage reporting.
Locally, make coverage runs in under 7 seconds.

If make coverage is not fast enough, I can remove the Makefile change.

Makefile change removed.

@coveralls
Copy link

coveralls commented Oct 2, 2024

Coverage Status

coverage: 60.998%. remained the same
when pulling bfdf757 on kurtmckee:skip-install-for-coverage-reporting
into ceb7141 on LudovicRousseau:master.

@LudovicRousseau
Copy link
Owner

make coverage takes 1.815s for me. 7 seconds is too slow.

I already reverted your changes in e6917e3
Why do you want to use tox here?

@kurtmckee
Copy link
Contributor Author

Because tox installs the package and ensures that developers are testing what they think they're testing.

I'll take out the Makefile change, though I recommend against it.

@kurtmckee kurtmckee force-pushed the skip-install-for-coverage-reporting branch from 1d2ce12 to bfdf757 Compare October 2, 2024 15:24
@LudovicRousseau LudovicRousseau merged commit 202f2ab into LudovicRousseau:master Oct 2, 2024
21 checks passed
@LudovicRousseau
Copy link
Owner

I install the package using this Makefile rule:

install: clean
	$(PYTHON) -m pip install --editable .

So I am always using the current source code.

@kurtmckee kurtmckee deleted the skip-install-for-coverage-reporting branch October 2, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants