-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize local and CI testing to use tox #184
Standardize local and CI testing to use tox #184
Conversation
b087d71
to
7a95190
Compare
Nice. |
* Use tox exclusively to manage test and build environments. This change standardizes make and CI invocations of the test suite. * Merge Windows testing in with the Linux and macOS test suite. This means that Linux and macOS wheels are now getting built and uploaded, and also means that coveralls is getting Windows coverage reports. * Support building wheels for all supported Python versions. This is accomplished using a tox label that expands to all supported Python versions. Run tox run -m build or make build to invoke this. * Support running the test suite across all Python versions in parallel. This is accomplished by running tox run-parallel or simply tox p. Cross-environment dependencies, like generating coverage reports after all tests have run, are managed in the tox configuration.
7a95190
to
419cce6
Compare
I've amended the commit and force-pushed. 👍 Please let me know if there's anything else that you'd like to see with this change. |
Why do you use Also I don't think the lines:
are used. Maybe the test should be something like |
tox.ini uses:
I think it should be:
now that the source code has been moved in |
Right you are! This worked locally (showing me a number of items that pylint caught) because I had a cached tox environment that had pyscard installed. I'm fixing this by removing |
Re: swig versionThat's a verbatim lift-and-shift of what was in Re: Windows setup stepsYep, I overlooked that during an update. I'll get that fixed. |
765d862
to
afeff77
Compare
I've pushed an update that uses |
This PR introduces the following changes:
Use tox exclusively to manage test and build environments.
This change standardizes
make
and CI invocations of the test suite.Merge Windows testing in with the Linux and macOS test suite.
This means that Linux and macOS wheels are now getting built and uploaded,
and also means that coveralls is getting Windows coverage reports.
Support building wheels for all supported Python versions.
This is accomplished using a tox label that expands to all supported Python versions.
Run
tox run -m build
ormake build
to invoke this.Support running the test suite across all Python versions in parallel.
This is accomplished by running
tox run-parallel
or simplytox p
.Cross-environment dependencies, like generating coverage reports after all tests have run,
are managed in the tox configuration.