Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support only Python 3.9 and higher #182

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

kurtmckee
Copy link
Contributor

@kurtmckee kurtmckee commented Sep 19, 2024

This PR introduces the following changes:

  • A python_requires option in setup.py restricts installs to Python 3.9+
  • PyPI trove classifiers, and a note in the docs index, advertise Python 3.9+ support
  • Tox and CI now test against Python 3.9+ across all platforms.

Closes #177


This PR begins the work to standardize testing across tools and environments.

There are at least five different ways to run the test suite, each with different commands:

  • The commands in the Makefile (pytest or unittest+coverage)
  • The commands in tox.ini (unittest+coverage)
  • CI for Linux and macOS (pytest+coverage)
  • CI for Windows (unittest)
  • Manual invocation (?)

To begin standardizing things, the Linux and macOS CI setup commands are now selected using in-YAML conditions (if:) rather than using bash conditionals. This helps prepare for the Windows CI job to integrate directly in with Linux and macOS.

Future standardization will eliminate pytest/unittest/coverage invocation differences.

@coveralls
Copy link

Coverage Status

coverage: 28.845%. remained the same
when pulling df3fbfe on kurtmckee:support-py39
into 9436613 on LudovicRousseau:master.

@LudovicRousseau LudovicRousseau merged commit ab32896 into LudovicRousseau:master Sep 19, 2024
19 checks passed
@LudovicRousseau
Copy link
Owner

Thanks

@kurtmckee kurtmckee deleted the support-py39 branch September 19, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What versions of Python are supported?
3 participants