Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #22

Merged
merged 2 commits into from
Jan 11, 2024
Merged

fix typos #22

merged 2 commits into from
Jan 11, 2024

Conversation

RainRat
Copy link
Contributor

@RainRat RainRat commented Jan 2, 2024

No description provided.

@DennisSoemers
Copy link
Collaborator

Thanks for the PR @RainRat, looks good.

@AchilleMorenville @epiette were you guys still working on setting up GitHub Actions to run tests, since we no longer have Travis?

Because this PR includes renamings of defines, which might break some games if the renamings haven't been done consistently across the board, I'm a bit wary of immediately merging this without any CI. If you guys think you might be able to get the GitHub actions correctly set up soonish, and merged into the official repo, I'd rather wait for that.

@DennisSoemers
Copy link
Collaborator

@RainRat When you sent the PR, we didn't have CI properly running anymore on this branch. Now we do again, but it didn't automatically trigger for your PR. Would you be able to merge our current dev back into your dev branch first? I think that should then likely trigger a CI run here too.

@DennisSoemers DennisSoemers merged commit 7bacc16 into Ludeme:dev Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants