Fix compat networks endpoint for a empty result

The networks list compat api endpoint must return `[]` and not `null` if no networks are found. Fixes containers#9293 Signed-off-by: Paul Holzinger <[email protected]>
Luap99 · Feb 9, 2021 · f2a8562 · f2a8562
1 parent f98605e
commit f2a8562
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/pkg/api/handlers/compat/networks.go b/pkg/api/handlers/compat/networks.go
@@ -196,7 +196,7 @@ func ListNetworks(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	var reports []*types.NetworkResource
+	reports := []*types.NetworkResource{}
 	logrus.Debugf("netNames: %q", strings.Join(netNames, ", "))
 	for _, name := range netNames {
 		report, err := getNetworkResourceByNameOrID(name, runtime, query.Filters)

diff --git a/test/apiv2/35-networks.at b/test/apiv2/35-networks.at
@@ -46,6 +46,9 @@ length=1 \
 # invalid filter filters={"dangling":["1"]}
 t GET networks?filters=%7B%22dangling%22%3A%5B%221%22%5D%7D 500 \
 .cause='invalid filter "dangling"'
+# (#9293 with no networks the endpoint should return empty array instead of null)
+t GET networks?filters=%7B%22name%22%3A%5B%22doesnotexists%22%5D%7D 200 \
+"[]"
 
 # network inspect docker
 t GET networks/a7662f44d65029fd4635c91feea3d720a57cef52e2a9fcc7772b69072cc1ccd1 200 \