Skip to content

Commit

Permalink
Swap bind address for gvproxy to localhost-only
Browse files Browse the repository at this point in the history
This resolves CVE-2021-4024, where an attacker could access the
API externally and forward any port they desired to the VM from
`podman machine`.

[NO NEW TESTS NEEDED] gvproxy is not tested directly at this
time.

Signed-off-by: Matthew Heon <[email protected]>
  • Loading branch information
mheon committed Dec 3, 2021
1 parent 815f36a commit 57c5e22
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/machine/qemu/machine.go
Original file line number Diff line number Diff line change
Expand Up @@ -659,7 +659,7 @@ func (v *MachineVM) startHostNetworking() error {

// Listen on all at port 7777 for setting up and tearing
// down forwarding
listenSocket := "tcp://0.0.0.0:7777"
listenSocket := "tcp://127.0.0.1:7777"
qemuSocket, pidFile, err := v.getSocketandPid()
if err != nil {
return err
Expand Down

0 comments on commit 57c5e22

Please sign in to comment.