Merge pull request containers#9838 from xordspar0/kubeVolumeErrors

Add problematic volume name to kube play error messages
Luap99 · Mar 28, 2021 · 4831d41 · 4831d41
2 parents ec47312 + dce877c
commit 4831d41
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/pkg/specgen/generate/kube/volume.go b/pkg/specgen/generate/kube/volume.go
@@ -116,7 +116,7 @@ func InitializeVolumes(specVolumes []v1.Volume) (map[string]*KubeVolume, error)
 	for _, specVolume := range specVolumes {
 		volume, err := VolumeFromSource(specVolume.VolumeSource)
 		if err != nil {
-			return nil, err
+			return nil, errors.Wrapf(err, "failed to create volume %q", specVolume.Name)
 		}
 
 		volumes[specVolume.Name] = volume

diff --git a/test/e2e/play_kube_test.go b/test/e2e/play_kube_test.go
@@ -1449,6 +1449,7 @@ spec:
 		kube := podmanTest.Podman([]string{"play", "kube", kubeYaml})
 		kube.WaitWithDefaultTimeout()
 		Expect(kube.ExitCode()).NotTo(Equal(0))
+		Expect(kube.ErrorToString()).To(ContainSubstring(defaultVolName))
 	})
 
 	It("podman play kube test with empty HostPath type volume", func() {