New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(generator): Remove duplicate checks in `isMiscType` #506

Merged

LuanRT merged 1 commit into LuanRT:main from absidue:generator-misc-perf

Sep 15, 2023

Collaborator

absidue commented Sep 15, 2023

Instead of checking typeof value === 'object' && value !== null in all 3 ifs, this pull request moves it to an if surrounding all 3 ifs.


          perf(generator): Remove duplicate checks in isMiscType

aeb17fe

github-actions bot added parser small-diff labels

LuanRT approved these changes

View reviewed changes

LuanRT merged commit 68df321 into LuanRT:main

3 checks passed

github-actions bot mentioned this pull request

chore(main): release 6.4.1 #507

Merged

absidue deleted the generator-misc-perf branch

September 15, 2023 18:30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

parser small-diff