Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Utils): Properly parse timestamps with thousands separators #363

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Mar 20, 2023

Description

Channels like Lofi Girl have 24/7 live streams, so when they end, the timestamps are massive https://www.youtube.com/@LofiGirl/streams, so long that they have a thousands separator for the hours. Currently the timestamp parsing can't handle the thousands separator. For this timestamp 20,843:43:51, instead of seeing it as having 20843 hours it instead only takes the digits before the separator, so 20 hours, the result being that the seconds duration on Video objects is a lot smaller than it should be.

This pull request removes any non digit characters before parsing the strings into numbers.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit 1c72a41 into LuanRT:main Mar 22, 2023
@absidue absidue deleted the fix-timestamp-parsing branch March 22, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants