Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PlayerMicroformat): Make the embed field optional #320

Merged
merged 1 commit into from
Feb 25, 2023

Conversation

absidue
Copy link
Collaborator

@absidue absidue commented Feb 24, 2023

Description

Videos like https://www.youtube.com/watch?v=HQMkxmtPZhg don't have the embed property in the player microformat response, which causes YouTube.js to log an error about not being able to access iframeUrl on undefined.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@LuanRT LuanRT merged commit a0e6cef into LuanRT:main Feb 25, 2023
@absidue absidue deleted the optional-embed-microformat branch February 25, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants