feat: Add is_live and is_upcoming to VideoDetails #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current
is_live_content
property only tells you whether the video is a normal one or a live stream, it doesn't provide enough granularity on whether the live stream is live, upcoming or a live stream replay, it's true for all three of those. Extracting theis_live
andis_upcoming
properties as well, solves that.Below is a table of the values of those 3 properties for the 4 types of videos mentioned above.
is_live
is_live_content
is_upcoming
true
true
false
false
true
false
false
true
true
false
false
false
I haven't added any tests as it'll be hard to find continously running live streams and upcoming live streams that never actually start.
Type of change
Checklist: