fix(MultiMarkersPlayerBar): avoid observing undefined objects

LuanRT · Mar 8, 2023 · f351770 · f351770
1 parent 0d35fe0
commit f351770
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/src/parser/classes/DecoratedPlayerBar.ts b/src/parser/classes/DecoratedPlayerBar.ts
@@ -2,14 +2,15 @@ import Parser from '../index.js';
 import { YTNode } from '../helpers.js';
 import type Button from './Button.js';
 import type MultiMarkersPlayerBar from './MultiMarkersPlayerBar.js';
+import type { RawNode } from '../index.js';
 
 class DecoratedPlayerBar extends YTNode {
   static type = 'DecoratedPlayerBar';
 
   player_bar: MultiMarkersPlayerBar | null;
   player_bar_action_button: Button | null;
 
-  constructor(data: any) {
+  constructor(data: RawNode) {
     super();
     this.player_bar = Parser.parseItem<MultiMarkersPlayerBar>(data.playerBar);
     this.player_bar_action_button = Parser.parseItem<Button>(data.playerBarActionButton);

diff --git a/src/parser/classes/MultiMarkersPlayerBar.ts b/src/parser/classes/MultiMarkersPlayerBar.ts
@@ -1,6 +1,7 @@
 import Parser from '../index.js';
 import type Chapter from './Chapter.js';
 import type Heatmap from './Heatmap.js';
+import type { RawNode } from '../index.js';
 
 import { observe, ObservedArray, YTNode } from '../helpers.js';
 
@@ -13,7 +14,7 @@ class Marker extends YTNode {
     chapters?: Chapter[];
   };
 
-  constructor (data: any) {
+  constructor (data: RawNode) {
     super();
     this.marker_key = data.key;
 
@@ -34,9 +35,12 @@ class MultiMarkersPlayerBar extends YTNode {
 
   markers_map: ObservedArray<Marker>;
 
-  constructor(data: any) {
+  constructor(data: RawNode) {
     super();
-    this.markers_map = observe(data.markersMap?.map((marker: { key: string; value: { [key: string ]: any }}) => new Marker(marker)));
+    this.markers_map = observe(data.markersMap?.map((marker: {
+      key: string;
+      value: { [key: string ]: any
+    }}) => new Marker(marker)) || []);
   }
 }