fix: improve type narrow with literal alias param during completion and signature help #2932
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports type narrow during completion and signature help when function params are using
@alias
with literal values, as requested here: #1456 (comment)Example use case:
中文版
上述 issue comment 作者想用
@alias
來定義 event name,因為這樣可以對 enum value 加 description,但發現用 alias 後做 completion 時無法做 type narrow。這個 PR 是想在做 completion 和 signature help 時,增加檢查 function param 對應的 literal values 是否符合 event name