Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vararg indices being unknown when iterated #2908

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

PennyJim
Copy link
Contributor

@PennyJim PennyJim commented Oct 23, 2024

Big thanks to @tomlau10 for basically writing the fix for me.

After some testing and trying any weird thing I could think of to break the fix, it seemed pretty bulletproof, but I wouldn't be surprised if I'm just not creative enough.

I went ahead and added a test and an entry to the changelog.
This is my first time contributing to luals, so I'd love constructive feedback. Like I feel like my wording is bad no matter how I think about wording things 😁

FIXES #2906

@tomlau10
Copy link
Contributor

tomlau10 commented Oct 23, 2024

Hi @PennyJim, you shall also add a line fix #2906 in your github PR comment. (you can just edit the current one)
This can let github to link this PR to close your original issue on merge. 👀
https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Similar to this one: #2888, where there is a FIXES #2887 in the PR comment.
Then the PR page will have something like Successfully merging this pull request may close these issues: #2906 on the right hand side of the page 😄

@sumneko sumneko merged commit efebc97 into LuaLS:master Oct 28, 2024
11 checks passed
@sumneko
Copy link
Collaborator

sumneko commented Oct 28, 2024

Thank you!

@PennyJim PennyJim deleted the unknown-vararg-itter-index branch October 28, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown Vararg indices when itterated
3 participants