add: placeholder for ${addons} for paths #2866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsakiller
added
enhancement
carsakiller
force-pushed
the
addon-path-placeholder
branch
from
d167595
to
021f817
Compare
|
@sewbacca, @fesily, @forestbelton, I could use some help testing this if any of you are running VS Code on Linux/MacOS. You should be able to just replace |
carsakiller
force-pushed
the
addon-path-placeholder
branch
from
021f817
to
7a2921b
Compare
|
Thank you for super quick turnaround on this, it is very appreciated! I'm using VS Code with WSL, and I was able to confirm that everything works when copying the new file in ✅ ScreenshotsUpdating
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finally doing what was promised long ago and adding an
${addons}variable/placeholder for paths so that people can specify, for example,${addons}/busted/module/libraryand it will resolve to the installation location for the addon manager.There are a lot of different platforms, which I could not all test myself. I have tested a few though:
The proper solution is probably to change the installation location for addons from the addon manager to go to
~/.luals/addonsrather than wherever VS Code has decided to throw them. It would then hopefully be much easier to find them and would be less dependent on VS Code. Something to keep in mind for the new addon manager, but unlikely to be implemented soon.