Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add prometheus #1707

Merged
merged 2 commits into from
Nov 22, 2022
Merged

feat: add prometheus #1707

merged 2 commits into from
Nov 22, 2022

Conversation

evan361425
Copy link
Contributor

Description by https://github.com/knyar/nginx-lua-prometheus

Usually it will be used by:

local prometheus = require("prometheus").init("prometheus_metrics")

not sure how to type the required module, helps needed.

@sumneko
Copy link
Collaborator

sumneko commented Nov 21, 2022

not sure how to type the required module, helps needed.

Add return PrometheusLib at the bottom of the file.

@evan361425
Copy link
Contributor Author

@sumneko fixed done, thanks!

@sumneko sumneko merged commit a933f2e into LuaLS:master Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evan361425 @sumneko