Merge pull request #1962 from jharajeev55/issue/1940

Array of a class type does not get completion #1940
LuaLS · Mar 2, 2023 · 0295ad8 · 0295ad8
2 parents 677fac0 + e5a99c3
commit 0295ad8
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 4 deletions.
diff --git a/script/vm/compiler.lua b/script/vm/compiler.lua
@@ -1908,10 +1908,9 @@ function vm.compileNode(source)
 
     ---@cast source parser.object
     vm.setNode(source, vm.createNode(), true)
-    if not vm.compileByGlobal(source) then
-        vm.compileByVariable(source)
-        compileByNode(source)
-    end
+    vm.compileByGlobal(source)
+    vm.compileByVariable(source)
+    compileByNode(source)
     compileByParentNode(source)
     matchCall(source)
 

diff --git a/test/crossfile/completion.lua b/test/crossfile/completion.lua
@@ -124,6 +124,37 @@ local function WITH_CONFIG(cfg, f)
     end
 end
 
+TEST {
+    {
+        path = 'abc.lua',
+        content = [[
+            ---@meta
+
+            ---@class A
+            ---@field f1 integer
+            ---@field f2 boolean
+            
+            ---@type A[]
+            X = {}
+]],
+    },
+    {
+        path = 'test.lua',
+        content = [[ X[1].<??>]],
+        main = true,
+    },
+    completion = {
+        {
+            label = 'f1',
+            kind = CompletionItemKind.Field,
+        },
+        {
+            label = 'f2',
+            kind = CompletionItemKind.Field,
+        },
+    }
+}
+
 TEST {
     {
         path = 'abc.lua',