Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger JK BLE SOC reset when using Step Mode #813

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Conversation

ArendsM
Copy link
Contributor

@ArendsM ArendsM commented Sep 20, 2023

@mr-manuel Could you please review the position of the SOC reset trigger while charge voltage control is in step mode? I'm not sure if that is the best position.

@mr-manuel
Copy link
Collaborator

There where you put the trigger_soc_reset() for step mode was not the same place as in linear mode. I moved it to the same place and added a check, that it's only called, if the charging mode is changing from bulk or absorption to float.

@mr-manuel mr-manuel merged commit fea0eff into Louisvdw:dev Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants