Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded to bevy 0.14.0 #1

Merged
merged 6 commits into from
Aug 8, 2024
Merged

upgraded to bevy 0.14.0 #1

merged 6 commits into from
Aug 8, 2024

Conversation

FloWi
Copy link
Contributor

@FloWi FloWi commented Jul 31, 2024

First of all thanks for sharing your cool project! Very helpful for beginners like me!

I'm currently learning rust and wanted to play around with bevy. I found your cool project and wanted to see how you did certain things in a debugging session. The bevy 0.10.x version didn't run on my mac locally and so I upgraded to 0.14.

If you're interested, please take a look. Keep in mind that I'm new to both rust and bevy and might have made silly mistakes.

Copy link
Owner

@Louis-Tarvin Louis-Tarvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for contributing! I'm glad you like the project.
The changes all look good to me. I'd appreciate it if you could use cargo fmt to format the files, although it's not essential (personally I have my editor format on save, which I recommend). Same goes for the clippy lints.

@FloWi
Copy link
Contributor Author

FloWi commented Aug 5, 2024

I'd appreciate it if you could use cargo fmt to format the files, although it's not essential (personally I have my editor format on save, which I recommend). Same goes for the clippy lints.

Sorry, my bad. I thought I had format-on-save turned on, but that was only in the other project and not globally. Still setting up my stuff for rust coding.
Should be good now.

@Louis-Tarvin Louis-Tarvin merged commit e76f8c2 into Louis-Tarvin:main Aug 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants