Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slots): add missing p prop, support animated-text-document & asset-image #52

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

Aidosmf
Copy link
Contributor

@Aidosmf Aidosmf commented Apr 10, 2024

lottie-web and ThorVG require p property inside a Slot object. In addition, Slots are possible in asset-image & animated-text-document

Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: 8aa6f43

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Aidosmf Aidosmf requested a review from mbasaglia April 10, 2024 07:57
@Aidosmf Aidosmf self-assigned this Apr 10, 2024
@Aidosmf Aidosmf added bug Something isn't working enhancement New feature or request labels Apr 10, 2024
@mbasaglia mbasaglia merged commit 8aa6f43 into LottieFiles:main Apr 10, 2024
1 check passed
@Aidosmf Aidosmf deleted the mf/fix-slots branch April 10, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants