Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARGO-715 added change to fall back to the TCF cookies when no data is… #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion modules/lotamePanoramaIdSystem.js
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,15 @@ export const lotamePanoramaIdSubmodule = {
if (consentData && utils.isBoolean(consentData.gdprApplies)) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm - i would have expected the unit tests to catch this so maybe an update is needed there but this entire block doesn't get entered if there is no consentData object populated.

queryParams.gdpr_applies = consentData.gdprApplies;
if (consentData.gdprApplies) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gdprApplies also gets populated by the cmp. Thus, it won't be present for this case where we look in the cookies. So we should remove this if statement

queryParams.gdpr_consent = consentData.consentString;
let consentString = consentData.consentString;
// If no consent string in the data, try to read it from 1st party cookies
if (!consentString) {
consentString = getFromStorage('eupubconsent-v2');
}
if (!consentString) {
consentString = getFromStorage('euconsent-v2');
}
queryParams.gdpr_consent = consentString;
}
}
const url = utils.buildUrl({
Expand Down
65 changes: 61 additions & 4 deletions test/spec/modules/lotamePanoramaIdSystem_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -440,10 +440,67 @@ describe('LotameId', function() {
});
});

it('should retrieve the id when decode is called', function() {
var id = lotamePanoramaIdSubmodule.decode('1234');
expect(id).to.be.eql({
'lotamePanoramaId': '1234'
describe('when gdpr applies and falls back to eupubconsent cookie', function () {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fallback to the cookies should have tests where consentdata and gdpr applies aren't populated as those are both populated by the cmp. The way the code is currently written will have no practical effect.

let request;
let callBackSpy = sinon.spy();
let consentData = {
gdprApplies: true,
consentString: undefined
};

beforeEach(function () {
getCookieStub
.withArgs('eupubconsent-v2')
.returns('consentGiven');

let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_applies=true&gdpr_consent=consentGiven'
);
});
});

describe('when gdpr applies and falls back to euconsent cookie', function () {
let request;
let callBackSpy = sinon.spy();
let consentData = {
gdprApplies: true,
consentString: undefined
};

beforeEach(function () {
getCookieStub
.withArgs('euconsent-v2')
.returns('consentGiven');

let submoduleCallback = lotamePanoramaIdSubmodule.getId({}, consentData).callback;
submoduleCallback(callBackSpy);

// the contents of the response don't matter for this
request = server.requests[0];
request.respond(200, responseHeader, '');
});

it('should call the remote server when getId is called', function () {
expect(callBackSpy.calledOnce).to.be.true;
});

it('should pass the gdpr consent string back', function() {
expect(request.url).to.be.eq(
'https://id.crwdcntrl.net/id?gdpr_applies=true&gdpr_consent=consentGiven'
);
});
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add one more where there are no cookies to fall back to confirming that we don't add the query params

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

});
});