Skip to content
This repository has been archived by the owner on Apr 27, 2020. It is now read-only.

Fixed detect script #2

Merged
merged 1 commit into from
Aug 4, 2017
Merged

Fixed detect script #2

merged 1 commit into from
Aug 4, 2017

Conversation

moravcik
Copy link
Contributor

Fixed #1, added echo "POST BUILD CLEAN" and exit 0 to detect script

@mcmillan
Copy link
Contributor

Hi @moravcik! Thanks for the PR. Can you squash your commits and we'll get this merged?

@moravcik
Copy link
Contributor Author

Hi @mcmillan, it took me a while to find out how to do the squash of commits, but it seems it is done now.

@rvetere
Copy link

rvetere commented Jun 12, 2016

please merge this 👍

@nruth nruth mentioned this pull request Oct 5, 2016
Closed
nruth
nruth approved these changes Oct 5, 2016
View reviewed changes
Copy link
Contributor

@nruth nruth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Installation fails without this change.

@davidguthu
Copy link

Why hasn't this been merged?

@moravcik
Copy link
Contributor Author

moravcik commented Aug 3, 2017

You can use my fork, if you like
https://github.com/moravcik/heroku-buildpack-post-build-clean

@mcmillan mcmillan merged commit 661cabd into Lostmyname:master Aug 4, 2017
@mcmillan
Copy link
Contributor

mcmillan commented Aug 4, 2017

Sorry for the delay in getting this merged, folks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nruth nruth nruth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@moravcik @mcmillan @rvetere @davidguthu @nruth