Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lara: fix jump-twist interruptions #933

Merged

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Aug 20, 2023

Resolves #932.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

The gravity check added as part of #890 was failing in some cases because there is a 4 frame window at the start of the jumping animation where gravity is zero, so if roll was pressed here the jump would be cancelled.

The changes here now reflect tomb3 (aside from the additional twist inputs, but that will be covered separately against #931).

@aredfan has done some additional animation testing with me on this build as follows to be thorough:

  • The original T-pose softlock issue from lara: fix jump-twist state softlock #890 under low ceilings
  • Running jump + action to grab a ledge
  • Running jump into a swan dive
  • Running jump off a ledge to enter fast fall
  • Backward jump off a ledge to enter fast fall
  • Normal backward jump into standing still state
  • Backward jump off a higher ledge, but not high enough to kill Lara

@lahm86 lahm86 added the TRX bug A bug with TRX label Aug 20, 2023
@lahm86 lahm86 added this to the 2.16 milestone Aug 20, 2023
@lahm86 lahm86 self-assigned this Aug 20, 2023
@lahm86 lahm86 requested review from rr- and walkawayy August 20, 2023 17:45
@lahm86 lahm86 merged commit 432ed36 into LostArtefacts:develop Aug 20, 2023
@lahm86 lahm86 deleted the issue-932-jump-twist-interruptions branch August 21, 2023 10:09
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR1 TRX bug A bug with TRX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

T1M bug: Jump animations get interrupted by specific inputs done in quick succession
3 participants