Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

music: add support for multiple file formats. #688

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

carlo-bramini
Copy link
Contributor

@carlo-bramini carlo-bramini commented Jan 5, 2023

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This patch adds support for more audio formats when playing audio tracks.

Copy link
Collaborator

@rr- rr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cosmetic remarks, other than that LGTM.

src/game/music.c Outdated
#include "specific/s_audio.h"

#include <stdio.h>

static const char *m_Extensions[] = { ".flac", ".ogg", "mp3", ".wav", NULL };
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mp3 has no ..

src/game/music.c Outdated
char file_path[64];

sprintf(file_path, "music/track%02d.flac", track);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary blank lines

src/game/music.c Show resolved Hide resolved
@rr- rr- added this to the 2.13 milestone Jan 5, 2023
@rr-
Copy link
Collaborator

rr- commented Jan 5, 2023

The commit message should spell music though without the caps.

@carlo-bramini carlo-bramini changed the title MUSIC: add support for multiple file formats. music: add support for multiple file formats. Jan 5, 2023
Copy link
Collaborator

@rr- rr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rr- rr- requested a review from walkawayy January 5, 2023 22:24
@walkawayy walkawayy added the Feature New functionality label Jan 6, 2023
@rr-
Copy link
Collaborator

rr- commented Jan 6, 2023

Actually this is missing a changelog entry.

This patch adds support for more audio formats when playing audio tracks.
@rr- rr- merged commit 343a105 into LostArtefacts:develop Jan 6, 2023
@carlo-bramini carlo-bramini deleted the fix-music-2 branch January 6, 2023 14:46
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality TR1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants