-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
music: add support for multiple file formats. #688
Conversation
b924dbe
to
edc2463
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cosmetic remarks, other than that LGTM.
src/game/music.c
Outdated
#include "specific/s_audio.h" | ||
|
||
#include <stdio.h> | ||
|
||
static const char *m_Extensions[] = { ".flac", ".ogg", "mp3", ".wav", NULL }; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mp3 has no .
.
src/game/music.c
Outdated
char file_path[64]; | ||
|
||
sprintf(file_path, "music/track%02d.flac", track); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unnecessary blank lines
The commit message should spell |
edc2463
to
88808d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Actually this is missing a changelog entry. |
This patch adds support for more audio formats when playing audio tracks.
88808d2
to
682859d
Compare
Checklist
Description
This patch adds support for more audio formats when playing audio tracks.