tr2/shell: fix exiting the game #2427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr-
added
TRX bug
rr-
requested review from
lahm86,
walkawayy and
aredfan
and removed request for
a team
lahm86
approved these changes
Feb 1, 2025
aredfan
approved these changes
Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Resolves #2425. Regression from 1240537, which attempted to optimize away a memory leak by destroying the main window. However, this action was performed too soon, causing certain subsystems to malfunction during the shutdown phase. As a result, since GL wasn't in a stable state, not only the textures would fail to be destroyed, but also the error handling routine activated during shutdown would get stuck in an infinite loop.