Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr1/cutscene: restore manual camera positioning #2426

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Feb 1, 2025

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change
  • I have added a readme entry about my new feature or OG bug fix, or it is a different change

Description

Fixes #2739 by bringing back the cutscene positioning game flow events. We had previously removed these in 718a1d7, thinking they didn't make a difference. Albeit subtle, turns out they do.

Fixes #2739 by bringing back the cutscene positioning game flow events.
We had previously removed these in 718a1d7, thinking they didn't make a
difference. Albeit subtle, turns out they do.
@rr- rr- added TRX bug A bug with TRX TR2 labels Feb 1, 2025
@rr- rr- self-assigned this Feb 1, 2025
@rr- rr- requested review from a team as code owners February 1, 2025 18:57
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team February 1, 2025 18:57
@rr- rr- added Unreleased Applies to things that aren't in a stable release. TR1 and removed TR2 labels Feb 1, 2025
Copy link
Collaborator

@lahm86 lahm86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for not testing this fully during the previous removal.

@aredfan aredfan linked an issue Feb 1, 2025 that may be closed by this pull request
@rr- rr- merged commit 8a6039b into develop Feb 1, 2025
9 checks passed
@rr- rr- deleted the issue-2379-cutscene-pos branch February 1, 2025 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TR1 TRX bug A bug with TRX Unreleased Applies to things that aren't in a stable release.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

TR1X bug: camera briefly moves through geology - CUT1
3 participants