tr2/flares: fix flare effects in shallow water #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
This ensures we test water height at a flare's exact positions rather than using Lara's general room number, so to determine if bubbles should spawn and how to play sound effects. Resolves LostArtefacts#1590.
lahm86
force-pushed
the
issue-1590-fix-flare-fx
branch
from
57b4f24 to
a056e29
Compare
aredfan
approved these changes
Dec 28, 2024
rr-
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1590.
Checklist
Description
This ensures we test water height at a flare's exact position rather than using Lara's general room number, so to determine if bubbles should spawn and how to play sound effects.