Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tr2/data: convert Catacombs music triggers to pads #1974

Merged
merged 1 commit into from
Nov 30, 2024

Conversation

lahm86
Copy link
Collaborator

@lahm86 lahm86 commented Nov 30, 2024

Resolves #1962.

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This converts some music triggers at the start of Catacombs to pads to retain the element of surprise when the yeti spawns.

Ref: LostArtefacts/TRXInjectionTool#15

@lahm86 lahm86 added OG bug A bug in original game Data Requires injecting content / files that are not a part of the original game TR2 labels Nov 30, 2024
@lahm86 lahm86 self-assigned this Nov 30, 2024
@lahm86 lahm86 requested review from a team as code owners November 30, 2024 10:03
@lahm86 lahm86 requested review from rr-, walkawayy and aredfan and removed request for a team November 30, 2024 10:03
Copy link

Copy link
Collaborator

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The FD fix is working as expected, LGTM.

Thank you again. 👍

This converts some music triggers at the start of Catacombs to pads to
retain the element of surprise when the yeti spawns.

Resolves LostArtefacts#1962.
@lahm86 lahm86 force-pushed the issue-1962-catacombs-pads branch from c7baf71 to a9dcdc3 Compare November 30, 2024 12:39
@lahm86 lahm86 merged commit 97ac10f into LostArtefacts:develop Nov 30, 2024
6 checks passed
@lahm86 lahm86 deleted the issue-1962-catacombs-pads branch November 30, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Requires injecting content / files that are not a part of the original game OG bug A bug in original game TR2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

OG bug: misuse of some triggers | Catacombs of the Talion
3 participants