tr2/inject: add support for floor data injection #1921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently supports reading basic bin files for TR2, no processing is done yet.
This adds the same FD injection support as per TR1.
This fixes the duplicated trigger in room 44 for the collapsible tile above. Resolves LostArtefacts#1902.
This injects flipmap dummy triggers for the drawbridge in Tibetan Foothills, plus the key trigger. Resolves LostArtefacts#1744.
This injects the death sector property into six sectors that are missing it in Temple of Xian room 91. Resolves LostArtefacts#1920.
lahm86
requested review from
rr-,
walkawayy and
aredfan
and removed request for
a team
|
Download the built assets for this pull request: |
aredfan
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1744.
Resolves #1902.
Resolves #1920.
Checklist
Description
This adds an injection framework similar to TR1, but is limited to floor data edits at the moment. We can build this up incrementally as needed. I've added three fixes for the time being as detailed in the linked issues. Floor data fixes are optional, just like TR1, and the config tool has been updated.