Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try OpenGL 3.3C first, and fall back to 2.1 only if it fails #1747

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Oct 24, 2024

Checklist

  • I have read the coding conventions
  • I have added a changelog entry about what my pull request accomplishes, or it is an internal change

Description

This is a blind fix for #1738.

@rr- rr- added TRX bug A bug with TRX TR1 labels Oct 24, 2024
@rr- rr- self-assigned this Oct 24, 2024
@rr- rr- requested review from a team as code owners October 24, 2024 08:03
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team October 24, 2024 08:03
@rr- rr- marked this pull request as draft October 24, 2024 08:03
Copy link

github-actions bot commented Oct 24, 2024

@rr- rr- force-pushed the issue-1738-amd-gpu-invalid-window-handle branch 2 times, most recently from 3881bd8 to 8e4a544 Compare October 25, 2024 20:15
@rr- rr- marked this pull request as ready for review October 25, 2024 22:28
@rr- rr- changed the title Try to fix invalid window handle error on certain AMD GPUs Try OpenGL 3.3C first, and fall back to 2.1 only if it fails Oct 25, 2024
@rr- rr- requested a review from aredfan October 25, 2024 22:30
@rr- rr- added Enhancement Improvement of an existing feature and removed TRX bug A bug with TRX labels Oct 25, 2024
@rr- rr- force-pushed the issue-1738-amd-gpu-invalid-window-handle branch from 8e4a544 to 93f47d2 Compare October 26, 2024 13:26
@rr- rr- force-pushed the issue-1738-amd-gpu-invalid-window-handle branch from 93f47d2 to 0244b21 Compare October 26, 2024 13:26
@rr- rr- merged commit 802740c into develop Oct 26, 2024
7 checks passed
@rr- rr- deleted the issue-1738-amd-gpu-invalid-window-handle branch October 26, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement of an existing feature TR1
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants