Crash when loading a save with spaz_effect_count set

[lahm86]

If the game is saved while Lara is in the following animation and then reloaded, a crash occurs. This is present in TombATI as well as T1M (found by Radgryd during randomizer testing).

Saving during Lara's normal animation doesn't lead to a crash.

The cause I think is that while spaz_effect_count and spaz_effect are saved, only spaz_effect_count is restored.

The crash seems to occur below as g_Lara.spaz_effect_count is used in the condition, but g_Lara.spaz_effect is assumed to be set.

https://github.com/LostArtefacts/Tomb1Main/blob/develop/src/game/lara/lara_control.c#L158

[lahm86]

Savefile for Atlantis for reference.
save_tr1_15.zip

[walkawayy]

Looks like it's a NULL pointer issue. Just trying to print g_Lara.spaz_effect->pos.x on load causes a crash. spaz_effect gets set to FX_INFO *fx = &g_Effects[fx_num]; depending on what caused it. Looks like that isn't being saved and restored properly in legacy or new save format.

[rr-]

Fixed in 2.13.2