Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fade skipping #541

Closed
Richard-L opened this issue May 6, 2022 · 3 comments · Fixed by #842
Closed

Improve fade skipping #541

Richard-L opened this issue May 6, 2022 · 3 comments · Fixed by #842
Labels
Feature New functionality TR1
Milestone

Comments

@Richard-L
Copy link
Collaborator

Richard-L commented May 6, 2022

Very nitpicky thing, but something you do notice after prolonged testing:

Currently the fades cannot be skipped via ESC or the action button. Take for example the initial EIDOS logo: you can only skip after fade-in, or before fade-out, but not during. It would be really nice if the skip behaviour were extended to all these three states: fade-in, image showing, fade-out.

I wonder where else this has an effect. I reckon during the end credits.

@rr-
Copy link
Collaborator

rr- commented May 7, 2022

You can skip it during but it just starts fade out sooner and doesn't immediately close.

@rr- rr- added the Feature New functionality label May 7, 2022
@Richard-L
Copy link
Collaborator Author

Yeah, that's what I meant by skipping while the image is showing. It will start the fade-out. But the fades themselves you cannot interrupt with a button press.

If this is annoying to change then nvm. I just think it's good to give people control. And I'm really feeling the fades each time I fire up the game for testing 😜

@walkawayy
Copy link
Collaborator

If you press ESC or action during the Eidos fade in, it will start to fade out instantly. So the faster you press, the shorter the fade out and skip.
Once the Eidos logo is fully faded in, you can't skip it.

rr- added a commit that referenced this issue May 18, 2023
@rr- rr- mentioned this issue May 18, 2023
2 tasks
@rr- rr- added this to the 2.15 milestone May 18, 2023
rr- added a commit that referenced this issue May 19, 2023
@rr- rr- closed this as completed in #842 May 19, 2023
rr- added a commit that referenced this issue May 19, 2023
@rr- rr- added the TR1 label Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality TR1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants