Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pause mode PS1 compatibility #2248

Closed
rr- opened this issue Jan 10, 2025 · 1 comment · Fixed by #2249
Closed

Improve pause mode PS1 compatibility #2248

rr- opened this issue Jan 10, 2025 · 1 comment · Fixed by #2249
Assignees
@rr-
Labels
Enhancement Improvement of an existing feature TR1 TR2

Comments

@rr-
Copy link
Collaborator

rr- commented Jan 10, 2025

2025-01-09.00-56-03.mp4

"Paused" shouldn't show until the fade is at 100%.

Also the fade is a few milliseconds too long (?) compared to OG in video above.

Originally posted by @Richard-L in #2234 (comment)
@rr- rr- moved this to In review in TRX Dev tracker Jan 10, 2025
@rr- rr- moved this from In review to In progress in TRX Dev tracker Jan 10, 2025
@rr- rr- self-assigned this Jan 10, 2025
@rr- rr- added Enhancement Improvement of an existing feature TR2 TR1 labels Jan 10, 2025
rr- added a commit that referenced this issue Jan 10, 2025
@rr-
phase/pause: improve ps1 compatibility
f1b9565 
Resolves #2248.
@rr- rr- mentioned this issue Jan 10, 2025
Merged
3 tasks
rr- added a commit that referenced this issue Jan 10, 2025
@rr-
phase/pause: improve ps1 compatibility
c000bea 
Resolves #2248.
@Richard-L
Copy link
Collaborator

Thanks dash. I literally didn't get to it yesterday.

@rr- rr- closed this as completed in #2249 Jan 10, 2025
rr- added a commit that referenced this issue Jan 10, 2025
@rr-
phase/pause: improve ps1 compatibility
3362551 
Resolves #2248.
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rr- rr-

Labels
Enhancement Improvement of an existing feature TR1 TR2
Projects
TRX Dev tracker
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

phase/pause: improve ps1 compatibility LostArtefacts/TRX
2 participants
@rr- @Richard-L