Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OG bug: skidoo can cause a crash in rooms with many neighbours #1987

Closed
lahm86 opened this issue Dec 5, 2024 · 0 comments · Fixed by #1988
Closed

OG bug: skidoo can cause a crash in rooms with many neighbours #1987

lahm86 opened this issue Dec 5, 2024 · 0 comments · Fixed by #1988
Assignees
@lahm86
Labels
OG bug A bug in original game TR2

Comments

@lahm86
Copy link
Collaborator

lahm86 commented Dec 5, 2024

If the Lara is on a skidoo in a room that has more than 12 (visibility) portals into other rooms, the game will likely crash.
@lahm86 lahm86 added OG bug A bug in original game TR2 labels Dec 5, 2024
@lahm86 lahm86 self-assigned this Dec 5, 2024
@lahm86 lahm86 moved this to In progress in TRX Dev tracker Dec 5, 2024
lahm86 added a commit to lahm86/TRX that referenced this issue Dec 5, 2024
@lahm86
libtrx/rooms/common: fix adjoining room array limit
d5eb63b 
This ensures we don't write beyond array bounds when scanning for a
room's neighbours, and specifically prevents the skidoo causing a
crash if in a room with many neighbours.

Resolves LostArtefacts#1987.
@lahm86 lahm86 mentioned this issue Dec 5, 2024
Merged
2 tasks
@lahm86 lahm86 closed this as completed in 9a0902f Dec 6, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in TRX Dev tracker Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lahm86 lahm86

Labels
OG bug A bug in original game TR2
Projects
TRX Dev tracker
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

libtrx/rooms/common: fix adjoining room array limit lahm86/TRX
1 participant
@lahm86