-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement adding data from config file #934
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this!
I started on common_subject
and worked up, so the 'why' might be in the later comments. All my comments are along the lines of "This old part of spyglass doesn't do this python thing that I think we'd be better off if we did". What you've got so far looks like it would work perfectly well, but I'm cutting down lines of code in my suggestions
Co-authored-by: Chris Brozdowski <[email protected]>
@calderast what is the status of this PR? is it mostly good to go (aside from the change requested above) or are you still working on things? |
@edeno - The use of I recommend reverting and using def func(a, config=None):
config = config or dict() |
We can just put in a quick PR to fix. |
Fixed in 08fa17c |
Implement adding data from config file
Allows users to specify Institution, Lab, LabMember, Subject, and CameraDevice information for an nwb file in the associated config file.
Checklist:
CITATION.cff
CHANGELOG.md