Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dlc video and kachery cloud config #882

Merged
merged 4 commits into from
Mar 21, 2024
Merged

Fix dlc video and kachery cloud config #882

merged 4 commits into from
Mar 21, 2024

Conversation

samuelbray32
Copy link
Collaborator

@samuelbray32 samuelbray32 commented Mar 21, 2024 •
edited
Loading

Description

Checklist:

  • This PR should be accompanied by a release: unsure
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 March 21, 2024 17:34
CBroz1
CBroz1 approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @samuelbray32 - Just one minor comment

@edeno edeno merged commit 3de6cdc into master Mar 21, 2024
5 checks passed
@edeno edeno deleted the config_settings_bug branch March 21, 2024 18:53
@edeno edeno mentioned this pull request Apr 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CBroz1 CBroz1 CBroz1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spyglass Config Bugs
3 participants
@samuelbray32 @CBroz1 @edeno