Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the length of object_id for ImportedSpikeSorting #760

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Fix the length of object_id for ImportedSpikeSorting #760

merged 1 commit into from
Jan 12, 2024

Conversation

khl02007
Copy link
Collaborator

Description

  • Previously it was too short and threw an error upon insert.
  • Also added ImportedSpikeSorting to the init of v1 and v0 so it can be called directly regardless of what version user imports.
  • I have tested the changes by importing spyglass.spikesorting.v1

Checklist:

  • This PR should be accompanied by a release: (yes/no/unsure)
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • I have added/edited docs/notebooks to reflect the changes

@edeno edeno merged commit 499edac into LorenFrankLab:master Jan 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edeno edeno edeno approved these changes

@CBroz1 CBroz1 Awaiting requested review from CBroz1

@samuelbray32 samuelbray32 Awaiting requested review from samuelbray32

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khl02007 @edeno