Dlc debug: smoothing_duration fix #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issue: Bug when running
sgp.DLCCentroid.populate(centroid_key): error outputsTypeError: spyglass.position.v1.dlc_utils.smooth_moving_avg() got multiple values for keyword argument 'smoothing_duration'Changes: delete line 229 in
/spyglass/src/spyglass/position/v1/position_dlc_centroid.py:smoothing_duration=smoothing_durationRelevant motivation and context: (explanation credits to Eric): the **dict expands the dictionary provided by
params["smoothing_params"]so that it becomes a keyword argument tosmooth_moving_avg.smooth_moving_avgtherefore has the two keyword arguments calledsmoothing_durationand doesn’t know which to use and errors./spyglass/src/spyglass/position/v1/position_dlc_centroid.py: delete the linesmoothing_duration = smoothing_durationChecklist:
CITATION.cffCHANGELOG.md