Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

positionVideo debug #687

Merged
merged 9 commits into from
Nov 17, 2023
Merged

positionVideo debug #687

merged 9 commits into from
Nov 17, 2023

Conversation

samuelbray32
Copy link
Collaborator

Description

Fixes several issues in the positionVideo make function

  • Minor changes to make the raw_dir string and access to the video file path in the nwbfile work correctly
  • Allow table to make videos with position data upsampled for decoding
  • Ensures proper selection of position data from the nwbfile spatial series across more versions of rec_to_nwb/trodes_to_nwb conversion. (now matches strategy in TrodesPosV1 pipeline from 59b68df)
  • Use the video_dir to access the video file

Checklist:

  • This PR should be accompanied by a release: unsure
  • (If release) I have updated the CITATION.cff
  • I have updated the CHANGELOG.md
  • [ na] I have added/edited docs/notebooks to reflect the changes

@samuelbray32 samuelbray32 requested a review from CBroz1 November 16, 2023 19:42
Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor questions on the col name handling but looks good

Please edit the changelog

Copy link
Member

@CBroz1 CBroz1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this @samuelbray32 !

@CBroz1 CBroz1 merged commit eb3b050 into master Nov 17, 2023
@edeno edeno deleted the position_video_debug branch November 17, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants